Skip to content

closes #449 - converted $field-switch-height to 30px in calc() call #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2018
Merged

closes #449 - converted $field-switch-height to 30px in calc() call #450

merged 1 commit into from
Apr 28, 2018

Conversation

zoul0813
Copy link
Member

@zoul0813 zoul0813 commented Apr 28, 2018 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix
  • What is the current behavior? (You can also link to an open issue here)
    $field-switch-height is unparsed in vfg.css from fieldSwitch.vue
  • What is the new behavior (if this is a feature change)?
    Converted $field-switch-height to 30px in fieldSwitch.vue to prevent the unparsed variable from being put into the compiledCSS.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    N/A
  • Other information:

@zoul0813 zoul0813 merged commit d843625 into vue-generators:master Apr 28, 2018
@zoul0813 zoul0813 deleted the feature/449-fix-unparsed-sass branch April 28, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

@dflock dflock Awaiting requested review from dflock

@lionel-bijaoui lionel-bijaoui Awaiting requested review from lionel-bijaoui

@cristijora cristijora Awaiting requested review from cristijora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoul0813 @icebob